New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular reference involving pagecontainer and jquery.mobile.navigation #7158

Closed
gabrielschulhof opened this Issue Feb 23, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@gabrielschulhof
Contributor

gabrielschulhof commented Feb 23, 2014

widgets/pagecontainer →
transitions/handlers→
transitions/concurrent→
transitions/transition→
jquery.mobile.navigation→
widgets/pagecontainer

transitions/transition needs jquery.mobile.navigation, because $.mobile.focusPage resides therein.

The method could be defined in helpers, or even page instead, and we would break this cycle.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 25, 2014

Contributor

This results in an error when you try to write an integration test where you $.testHelper.asyncLoad([ "widgets/pagecontainer" ], [ "jquery.mobile.init" ]);

Contributor

gabrielschulhof commented Feb 25, 2014

This results in an error when you try to write an integration test where you $.testHelper.asyncLoad([ "widgets/pagecontainer" ], [ "jquery.mobile.init" ]);

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 25, 2014

Contributor

... such as a possible test for #7148 ...

Contributor

gabrielschulhof commented Feb 25, 2014

... such as a possible test for #7148 ...

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 20, 2015

Transitions: Aquire transition scrollTo data via parameter
This avoids dependence on navigation history

Fixes gh-7158

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 20, 2015

Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-4022
Fixes gh-7158

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 22, 2015

Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-4022
Fixes gh-7158

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 28, 2015

Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-6929
Fixes gh-4022
Fixes gh-7158

kapilgarg1996 added a commit to kapilgarg1996/jquery-mobile that referenced this issue Jun 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment