Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug in pagecontaner.js (v1.4.x) #7177
Pagecontaner widget has _handleDestination private method. The last 'if' statement in this method contains comparison:
However this comparison always evaluates to true because left part refers to full URL and the right part refers to just the hash part (with the # stripped out).
added a commit
Aug 16, 2014
In the process of removing
At this point, the location will display /path1/#page2 instead of /path2/#page2. This is bad, because opening an internal page should only change the hash, not the path.
The sequence tests should've caught this but I forgot to include an assertion that checks the location :(
@arschmitz do you think this is bad enough to warrant a fix?