External Panel loose correct _openedPage randomly after multiple page change #7236

Closed
magourex opened this Issue Mar 11, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@magourex

Using 2x externals panels,
After many page change one panel does not opened correctly (panel's _wrapper is not set correctly and the panel open on the wrong page)

Test page : http://jsbin.com/dawutofa/5/edit
see also 1.4.2 demo page : http://demos.jquerymobile.com/1.4.2/panel-external-internal/
Steps to reproduce:

  1. Click "Panel1 from page 1" and change to page 2
  2. Click "Panel2 from page 2" and change to page 1

repeat this until the panel no longer appears {

  • Click "Panel1 from page 1" and change to page 2
  • Click "Panel1 from page 2" and change to page 1

}

reproduce on firefox 27 & chromium 32

I have temporaly solve this issue by reseting _openedPage to null after pageshow on panel's _bindPageEvents function

gabrielschulhof added a commit that referenced this issue Apr 24, 2014

Panel: Bail upon opening animationComplete() if the panel has closed
Hook up animationComplete() to the wrapper, not the element, because that's
the element to which the animation class is added

Closes gh-7264
Fixes gh-7236

gabrielschulhof added a commit that referenced this issue Apr 24, 2014

Panel: Bail upon opening animationComplete() if the panel has closed
Hook up animationComplete() to the wrapper, if present, and only otherwise to
the element, because the animation class is only added to the element if there
is no wrapper.

The tests now need to wait for the panel to actually open in order to hit all
the assertions, because some assertions are made only upon panelopen.

(cherry picked from commit 301f124)

Closes gh-7264
Fixes gh-7236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment