New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Deprecate style options #7303

Closed
hyunsook opened this Issue Apr 8, 2014 · 2 comments

Comments

Projects
None yet
4 participants
@hyunsook
Contributor

hyunsook commented Apr 8, 2014

Hi Jasper,

As we already discussed, we are going to make for 1.5 to remove style options from widgets. So, my team creates new ticket for Button widget to start the tasks.
And, my team will upload changes that we removed the style options of Button widget right after this ticket.

Thanks,
Hyunsook

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Apr 8, 2014

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Apr 8, 2014

allsteady pushed a commit to allsteady/jquery-mobile that referenced this issue Apr 9, 2014

allsteady
Button: Modify the code to improve a minor performance.
Modify the code in'_parseClasses' function.

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Apr 24, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Apr 25, 2014

Button: Remove some style options form the widget.
Add css rule for negating a style option.

 - data-corner
 - data-shadow

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Apr 25, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Apr 25, 2014

Button: Remove some style options form the widget.
Add css rule for negating a style option.

 - data-corner
 - data-shadow

CSS rules are moved to theme.css.

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue May 9, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue May 13, 2014

Demos: Modify elements which use data-xxx to use data-wrapper-class.
Modify elements which use data-xxx='false' to use data-wrapper-class.

 - data-corner
 - data-shadow

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue May 20, 2014

@jaspermdegroot jaspermdegroot changed the title from Button : Removed style options to Button : Deprecate style options May 27, 2014

@jaspermdegroot jaspermdegroot changed the title from Button : Deprecate style options to Deprecate style options May 27, 2014

@jaspermdegroot jaspermdegroot changed the title from Deprecate style options to Button: Deprecate style options May 27, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue May 28, 2014

Button: Remove some style options form the widget
Add css rule for negating a style option.

 - data-corner
 - data-shadow

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue May 28, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jun 3, 2014

Theme: Remove some style options form the widget
Add css rule for negating a style option.

 - data-corner
 - data-shadow

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jun 3, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jun 3, 2014

Theme: Remove some style options form the widget
Add css rule for negating a style option.

 - data-corner
 - data-shadow

Fixes gh-7303

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jun 3, 2014

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 3, 2014

Member

Wiki: https://github.com/jquery/jquery-mobile/wiki/1.5-Style-options-removal

  • PR against branch "style-option-deprecation" #7464
    • Add new classes to negate styles in theme CSS
    • Add deprecated comments in Button widget JS
    • Update demos (check all demos because we use buttons everywhere)
  • API docs PR against branch "1-5" - jquery/api.jquerymobile.com#310
  • Add instructions to 1.5 upgrade guide - PR in jquerymobile.com repo against branch "1.5-update"
  • Update and test the ThemeRoller
  • Open a new ticket for removing Button style options (milestone 1.6) with checklist:
    • Remove code and comments
    • Remove deprecation notes from demos
    • Update tests
    • API docs PR: remove the options
    • Copy instructions from 1.5 upgrade guide to 1.6 upgrade guide; replace deprecated by removed
Member

jaspermdegroot commented Jun 3, 2014

Wiki: https://github.com/jquery/jquery-mobile/wiki/1.5-Style-options-removal

  • PR against branch "style-option-deprecation" #7464
    • Add new classes to negate styles in theme CSS
    • Add deprecated comments in Button widget JS
    • Update demos (check all demos because we use buttons everywhere)
  • API docs PR against branch "1-5" - jquery/api.jquerymobile.com#310
  • Add instructions to 1.5 upgrade guide - PR in jquerymobile.com repo against branch "1.5-update"
  • Update and test the ThemeRoller
  • Open a new ticket for removing Button style options (milestone 1.6) with checklist:
    • Remove code and comments
    • Remove deprecation notes from demos
    • Update tests
    • API docs PR: remove the options
    • Copy instructions from 1.5 upgrade guide to 1.6 upgrade guide; replace deprecated by removed

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jul 15, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jul 15, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jul 22, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Jul 22, 2014

allsteady pushed a commit to allsteady/jquery-mobile that referenced this issue Aug 22, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Aug 22, 2014

allsteady added a commit to allsteady/jquery-mobile that referenced this issue Aug 22, 2014

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Oct 23, 2014

Member

Closing this since we are going with new UI widget with classes option in 1.5

Member

arschmitz commented Oct 23, 2014

Closing this since we are going with new UI widget with classes option in 1.5

@arschmitz arschmitz closed this Oct 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment