New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: dynamicBaseEnabled does not seem to work #7331

Closed
frequent opened this Issue Apr 22, 2014 · 3 comments

Comments

Projects
None yet
4 participants
@frequent
Contributor

frequent commented Apr 22, 2014

JSBIN: here

According to the docs, setting dynamicBaseEnabled: false will not make JQM handle the base tag.

From the JQM source code, I would expect this option to not insert an unwanted base. But if you check the JSBIN, the base tag is injected, although the option is set.

Upon looking further, it boils down to why is the <base> tag inserted when the user wants to manage it?

@tjhiggins

This comment has been minimized.

Show comment
Hide comment
@tjhiggins

tjhiggins commented Sep 9, 2014

+1

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Jan 2, 2015

@gabrielschulhof gabrielschulhof self-assigned this Jan 2, 2015

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Jan 2, 2015

Contributor

I think the base tag is inserted, but it is not updated. I will nevertheless make the insertion of a base tag contingent upon the presence of dynamicBaseEnabled.

Contributor

gabrielschulhof commented Jan 2, 2015

I think the base tag is inserted, but it is not updated. I will nevertheless make the insertion of a base tag contingent upon the presence of dynamicBaseEnabled.

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 2, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 2, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 2, 2015

@frequent

This comment has been minimized.

Show comment
Hide comment
@frequent

frequent Jan 3, 2015

Contributor

@gabrielschulhof: Cool. Thanks a lot! And happy new year!

Contributor

frequent commented Jan 3, 2015

@gabrielschulhof: Cool. Thanks a lot! And happy new year!

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 9, 2015

kakul added a commit to kakul/jquery-mobile that referenced this issue Apr 14, 2015

Navigation: Remove fallback for browsers lacking dynamic base support
Do not unconditionally inject base tag

Fixes gh-7331
Fixes gh-5757
Fixes gh-7489
Closes gh-7895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment