Popup: Dynamic popup demo broken #7336

Closed
gabrielschulhof opened this Issue Apr 23, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@gabrielschulhof
Contributor

gabrielschulhof commented Apr 23, 2014

You need to properly enhance the popup first. First reported in #7290.

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Apr 23, 2014

@gabrielschulhof gabrielschulhof self-assigned this Apr 23, 2014

gabrielschulhof added a commit that referenced this issue Apr 23, 2014

Popup: Correctly enhance popup and its contents before opening
This is a better fix than the one provided in the original PR for this, because
it avoids the use of .enhanceWithin(), and it moves the image width/height
retrieval to popupbeforeposition, which is correct, because during creation the
popup is truncated to 1px x 1px.

Closes gh-7290
Fixes gh-7336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment