Table: Columntoggle toggles column even if checkbox programmatically stays unchecked #7381

Closed
gabrielschulhof opened this Issue May 8, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@gabrielschulhof
Contributor

gabrielschulhof commented May 8, 2014

http://jsbin.com/IFolanOW/425/

To reproduce, click repeatedly on 'Uncheck "Year"'.

At this point, you will notice that, instead of the "Year" column disappearing and then staying hidden in response to subsequent clicks, it toggles.

This is due to

if ( input[ 0 ].getAttribute( "locked" ) ) {
input.removeAttr( "locked" );
this._unlockCells( input.jqmData( "cells" ) );
} else {
input.attr( "locked", true );
}
where _unlockCells() in effect reveals the column every other time.

That whole section of code needs to go, because the attribute "locked" is not a valid attribute for a checkbox, the attribute is not data-prefixed, and it's not used anywhere else in the columntoggle code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment