Selectmenu: Use placeholder for dialog title, not label #7399

Closed
gabrielschulhof opened this Issue May 14, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@gabrielschulhof
Contributor

gabrielschulhof commented May 14, 2014

For consistency with the popup-based version, the dialog-based selectmenu should use the placeholder menu item, if any, rather than the label associated with the selectmenu, like it does now.

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone May 14, 2014

@gabrielschulhof gabrielschulhof self-assigned this May 14, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 14, 2014

Contributor

The problem is in _decideFormat(). There's another problem too: We're using self.label.text() to set the title of the dialog, not self.label.getEncodedText(), which #2547 and #2550 have established is the right way to copy text from one part of the DOM to another while avoiding potential XSS issues.

Contributor

gabrielschulhof commented May 14, 2014

The problem is in _decideFormat(). There's another problem too: We're using self.label.text() to set the title of the dialog, not self.label.getEncodedText(), which #2547 and #2550 have established is the right way to copy text from one part of the DOM to another while avoiding potential XSS issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment