New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectmenu: Find label when <select> element has weird ID #7401

Closed
gabrielschulhof opened this Issue May 14, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@gabrielschulhof
Contributor

gabrielschulhof commented May 14, 2014

This issue is similar to #6052, except this breaks the page, because autoinit of the <select> element fails so the whole autoinit is torn down, leaving the loader in place forever.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone May 14, 2014

@gabrielschulhof gabrielschulhof self-assigned this May 14, 2014

@gabrielschulhof gabrielschulhof changed the title from Selectmenu: Find label when ```<select>``` element has weird ID to Selectmenu: Find label when <select> element has weird ID May 14, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 14, 2014

Contributor

Boy! This issue reveals problems in the popup widget too. It's not sufficient to escape the ID when looking for the label. A custom selectmenu with a weird ID will cause a popup with a weird ID to be created, as well as a popup container, popup screen, listview, etc. The ID needs to be escaped in all selectors.

Contributor

gabrielschulhof commented May 14, 2014

Boy! This issue reveals problems in the popup widget too. It's not sufficient to escape the ID when looking for the label. A custom selectmenu with a weird ID will cause a popup with a weird ID to be created, as well as a popup container, popup screen, listview, etc. The ID needs to be escaped in all selectors.

@gabrielschulhof gabrielschulhof modified the milestones: 1.5 - 2.0, 1.4.3 May 14, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 14, 2014

Contributor

Oh, and let's not forget pagecontainer. The dialog generated for the selectmenu when the menu is large also has an ID based on the ID of the selectmenu, so if the selectmenu's ID is weird, so will the dialog's be, and so will its data-url attribute.

Contributor

gabrielschulhof commented May 14, 2014

Oh, and let's not forget pagecontainer. The dialog generated for the selectmenu when the menu is large also has an ID based on the ID of the selectmenu, so if the selectmenu's ID is weird, so will the dialog's be, and so will its data-url attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment