"Filterable inside custom select" demo fails on pressing ENTER in search field. #7405

Closed
slavap opened this Issue May 14, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@slavap

slavap commented May 14, 2014

See http://demos.jquerymobile.com/1.4.2/selectmenu-custom-filter/

form.submit( function () { return false; } ); // fix for ENTER key press

must be added after form creation.

Also there should be else branch added to if clause:
if ( !form ) { ... }
else { input = form.find( "input" ); }

@slavap

This comment has been minimized.

Show comment
Hide comment
@slavap

slavap May 14, 2014

Also check commas in your var declarations.

var input,
    list = $( event.target )
    form = list.jqmData( "filter-form" );

IMO must be:

var input,
    list = $( event.target ),
    form = list.jqmData( "filter-form" );

Look at "listviewcreate" and "pagebeforeshow"

slavap commented May 14, 2014

Also check commas in your var declarations.

var input,
    list = $( event.target )
    form = list.jqmData( "filter-form" );

IMO must be:

var input,
    list = $( event.target ),
    form = list.jqmData( "filter-form" );

Look at "listviewcreate" and "pagebeforeshow"

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 20, 2014

Contributor

@slavap thanks for the heads-up. The submit issue is already fixed in the latest version.

Contributor

gabrielschulhof commented May 20, 2014

@slavap thanks for the heads-up. The submit issue is already fixed in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment