New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxradio: Deprecate style option mini #7463

Closed
gabrielschulhof opened this Issue Jun 3, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Jun 3, 2014

There's a caveat with removal of the mini option:

<label>Checkbox<input type="checkbox" data-wrapper-class="ui-mini"></label>

will not result in a mini checkbox, because the wrapperClass option is examined during the creation of the wrapper in _wrapper() which is called from _enhance(), but then _enhance() calls _setOptions({ ... mini: this.options.mini, ... }) which causes the removal of the ui-mini class, because the default value for the mini option is false.

One possible solution to this is to remove the addition of the this.options.wrapperClass from _wrapper() and to add wrapperClass: this.options.wrapperClass to the _setOptions() call being made from _enhance().

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Jun 3, 2014

@jaspermdegroot jaspermdegroot changed the title from Checkboxradio: Style option removal to Checkboxradio: Deprecate style option mini Jun 3, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 3, 2014

Member

Wiki: https://github.com/jquery/jquery-mobile/wiki/1.5-Style-options-removal

  • PR against branch "style-option-deprecation" #7466
    • Code changes
    • Add deprecated comments in Checkboxradio widget JS
    • Update all demos that use a checkbox or radio
  • API docs PR against branch "1-5" jquery/api.jquerymobile.com#311
  • Add instructions to 1.5 upgrade guide - PR in jquerymobile.com repo against branch "1.5-update"
  • Update and test the ThemeRoller
  • Open a new ticket for removing Checkboxradio style options (milestone 1.6) with checklist:
    • Remove code and comments
    • Remove deprecation notes from demos
    • Update tests
    • API docs PR: remove option mini
    • Copy instructions from 1.5 upgrade guide to 1.6 upgrade guide; replace deprecated by removed
Member

jaspermdegroot commented Jun 3, 2014

Wiki: https://github.com/jquery/jquery-mobile/wiki/1.5-Style-options-removal

  • PR against branch "style-option-deprecation" #7466
    • Code changes
    • Add deprecated comments in Checkboxradio widget JS
    • Update all demos that use a checkbox or radio
  • API docs PR against branch "1-5" jquery/api.jquerymobile.com#311
  • Add instructions to 1.5 upgrade guide - PR in jquerymobile.com repo against branch "1.5-update"
  • Update and test the ThemeRoller
  • Open a new ticket for removing Checkboxradio style options (milestone 1.6) with checklist:
    • Remove code and comments
    • Remove deprecation notes from demos
    • Update tests
    • API docs PR: remove option mini
    • Copy instructions from 1.5 upgrade guide to 1.6 upgrade guide; replace deprecated by removed

gabrielschulhof added a commit that referenced this issue Jun 3, 2014

Checkboxradio: Deprecate option "mini"
This marks the occurrences of the option as deprecated, and moves processing of
the initial value of wrapperClass from _wrapper() to _setOptions(), so that
ui-mini will be applied if it's present in wrapperClass even if the mini option
is false.

Note that this requires the wrapperClass option to be processed after the mini
option in _setOptions().

Fixes gh-7463

agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014

Checkboxradio: Deprecate option "mini"
This marks the occurrences of the option as deprecated, and moves processing of
the initial value of wrapperClass from _wrapper() to _setOptions(), so that
ui-mini will be applied if it's present in wrapperClass even if the mini option
is false.

Note that this requires the wrapperClass option to be processed after the mini
option in _setOptions().

Closes gh-7466
Fixes gh-7463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment