Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Closing Dialog opened from Popup redirects to first screen in screen chain #7538
1 Add Foo, Bar pages and Baz dialog
After Baz Dialog has closed by Close button we stay on screen Bar
The defining characteristic of a dialog widget (not a page styled as a dialog) is that nav opens it using special logic, rendering the URL unreachable via dialogHashKey. On the flipside, when a navigate event occurs onto a history entry that has the dialogHashKey, nav invokes the dialog special logic. That logic checks whether the current page is a dialog, and if so, it navigates to the previous dialog. Otherwise, it skips over the current history entry via back() or forward().
The problem is that it checks whether the current page is a dialog by checking whether the current page has the class ui-dialog. This is incorrect, because a page widget with the dialog option set to true also has this class.
In the above sequence, the popup causes a history entry with a dialogHashKey to appear, followed by a history entry containing #baz, which is a page styled as a dialog, not a dialog widget. When you navigate back() from the dialog, the current page contains the class ui-dialog, and the hash contains the dialogHashKey, making it appear that you are on a dialog page. However, this is not the case, and you must not handle the navigate event using the dialog special logic.
Thus, we need to modify the check that identifies the current page as a dialog. Since the presence/absence of the ui-dialog class is no longer indicative, let's use