Rangeslider slidestart event bug #7597

Closed
eric-mesaros opened this Issue Jul 30, 2014 · 2 comments

Projects

None yet

2 participants

@eric-mesaros

The Rangeslider Widget fails to fire the slidestart event on the first handle.
Rangeslider is expected to fire the slidestart event for both handles, but only fires it for the second handle.

Fails in jQuery Mobile 1.4.2 and 1.4.3
Test page: http://jsfiddle.net/eric_mesaros/7cwv81qk/ (Apologies. I had some difficulty learning how to make fiddles public.)

A temporary fix was found by manually firing the start event on the first input from the _dragFirstHandle method (see test page).

@arschmitz
Member

@eric-mesaros thank you for reporting this I can confirm this issue. The problem is here https://github.com/jquery/jquery-mobile/blob/master/js/widgets/forms/rangeslider.js#L94 where we return false we need to probably manually trigger the event here.

@cgack cgack added a commit to cgack/jquery-mobile that referenced this issue Aug 21, 2014
@cgack cgack Rangeslider: trigger slidestart on first handle
Fixes gh-7597
484f494
@arschmitz arschmitz closed this in 588cf5b Aug 21, 2014
@eric-mesaros

You are very welcome. Thanks for helping to develop and maintain such
wonderful library!

On Thu, Aug 21, 2014 at 4:46 PM, Alexander Schmitz <notifications@github.com

wrote:

Closed #7597 #7597 via
588cf5b
588cf5b
.


Reply to this email directly or view it on GitHub
#7597 (comment).

@arschmitz arschmitz added a commit that referenced this issue Aug 26, 2014
@cgack @arschmitz cgack + arschmitz Rangeslider: trigger slidestart on first handle
Fixes gh-7597
Closes gh-7637

(cherry picked from commit 588cf5b)
e31e599
@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@cgack @agcolom cgack + agcolom Rangeslider: trigger slidestart on first handle
Fixes gh-7597
Closes gh-7637
8dda12b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment