New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textinput: Textarea must not contain a clear button #7605

Closed
gabrielschulhof opened this Issue Aug 2, 2014 · 3 comments

Comments

Projects
None yet
1 participant
@gabrielschulhof
Contributor

gabrielschulhof commented Aug 2, 2014

Currently the clearButton extension adds the anchor even to a textarea. A textarea must only contain text nodes.

@gabrielschulhof gabrielschulhof added this to the 1.4.4 milestone Aug 2, 2014

@gabrielschulhof gabrielschulhof self-assigned this Aug 2, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
Contributor

gabrielschulhof commented Aug 2, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 2, 2014

Contributor

Unfortunately, this is a regression from 1.3.2: http://jsbin.com/IFolanOW/549/

Contributor

gabrielschulhof commented Aug 2, 2014

Unfortunately, this is a regression from 1.3.2: http://jsbin.com/IFolanOW/549/

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 2, 2014

Contributor

It's also added to sliders: http://jsbin.com/IFolanOW/551/

Contributor

gabrielschulhof commented Aug 2, 2014

It's also added to sliders: http://jsbin.com/IFolanOW/551/

gabrielschulhof added a commit that referenced this issue Aug 22, 2014

Textinput: Do not concatenate clearBtnText value into HTML snippet
clearBtnText must be assigned via .attr( "title" ) to the title and via .text()
to the contents of the clear button anchor.

Do not append clear button to textarea elements.

(cherry picked from commit 5197c10)

Closes gh-7604
Fixes gh-7603
Fixes gh-7605

agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014

Textinput: Do not concatenate clearBtnText value into HTML snippet
clearBtnText must be assigned via .attr( "title" ) to the title and via .text()
to the contents of the clear button anchor.

Do not append clear button to textarea elements.

Closes gh-7604
Fixes gh-7603
Fixes gh-7605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment