Nav Buttons are always data-inline=TRUE in 1.4.3 change since 1.4.2 #7606

Closed
agador opened this Issue Aug 3, 2014 · 5 comments

Projects

None yet

2 participants

@agador
agador commented Aug 3, 2014

1.4.2. JS Fiddle: http://jsfiddle.net/jrbooth3/8r4Ty/

Buttons in NAV Bar in 1.4.2 default to full cell width. Can be "shortened" using data-inline=TRUE

1.4.3 JS Fiddle: http://jsfiddle.net/jrbooth3/LExhS/

Buttons in NAV Bar in 1.4.3 are always data-inline=TRUE. even specifying data-inline=FALSE has no effect.

Jim

1.4.2 output:
screen shot 2014-08-03 at 2 52 26 pm

1.4.3 output:

screen shot 2014-08-03 at 2 52 01 pm

@agador
agador commented Aug 4, 2014

Can be overridden by specifying style="width:100%;" in each tag in a NAVBAR that requires a full cell width button. Shouldn't this be the default action?

@jaspermdegroot
Member

@agador

Thanks for reporting the issue. This is indeed a bug. It's a regression from 1ed6f92. Currently we say the framework makes all buttons inside toolbars default to inline and mini style (we are going to deprecate this behaviour in 1.5: #7574) and this commit was to solve an inconsistency. [edit: However, buttons in navbars shouldn't have been affected by this.] All our navbar examples only contain anchor elements, so this problem with button elements hasn't been noticed.

@jaspermdegroot jaspermdegroot added this to the 1.4.4 milestone Aug 7, 2014
@jaspermdegroot jaspermdegroot self-assigned this Aug 7, 2014
@jaspermdegroot
Member

@arschmitz

I just noticed there are also issues with navbars with button elements when the navbar is not in a toolbar. In that case the buttons get shadow and corner style.
Is button elements in navbars something we don't support? I didn't see anything about it in the documentation. Although it's meant for navigation (links) I can imagine people want to use a navbar instead of a controlgroup because of it's full width style and grid.

@jaspermdegroot
Member

We just discussed this during our meeting and we do want to support button elements in navbars so we are going to fix this.

@agador
agador commented Aug 8, 2014

Thanks for the updates.

Jim

@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@jaspermdegroot @agcolom jaspermdegroot + agcolom Navbar: Fixed styling of button elements
Fixes gh-7606
7d58f42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment