Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Nav Buttons are always data-inline=TRUE in 1.4.3 change since 1.4.2 #7606
1.4.2. JS Fiddle: http://jsfiddle.net/jrbooth3/8r4Ty/
Buttons in NAV Bar in 1.4.2 default to full cell width. Can be "shortened" using data-inline=TRUE
1.4.3 JS Fiddle: http://jsfiddle.net/jrbooth3/LExhS/
Buttons in NAV Bar in 1.4.3 are always data-inline=TRUE. even specifying data-inline=FALSE has no effect.
Thanks for reporting the issue. This is indeed a bug. It's a regression from 1ed6f92. Currently we say the framework makes all buttons inside toolbars default to inline and mini style (we are going to deprecate this behaviour in 1.5: #7574) and this commit was to solve an inconsistency. [edit: However, buttons in navbars shouldn't have been affected by this.] All our navbar examples only contain anchor elements, so this problem with button elements hasn't been noticed.
I just noticed there are also issues with navbars with button elements when the navbar is not in a toolbar. In that case the buttons get shadow and corner style.