New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Buttons are always data-inline=TRUE in 1.4.3 change since 1.4.2 #7606

Closed
agador opened this Issue Aug 3, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@agador

agador commented Aug 3, 2014

1.4.2. JS Fiddle: http://jsfiddle.net/jrbooth3/8r4Ty/

Buttons in NAV Bar in 1.4.2 default to full cell width. Can be "shortened" using data-inline=TRUE

1.4.3 JS Fiddle: http://jsfiddle.net/jrbooth3/LExhS/

Buttons in NAV Bar in 1.4.3 are always data-inline=TRUE. even specifying data-inline=FALSE has no effect.

Jim

1.4.2 output:
screen shot 2014-08-03 at 2 52 26 pm

1.4.3 output:

screen shot 2014-08-03 at 2 52 01 pm

@agador

This comment has been minimized.

Show comment
Hide comment
@agador

agador Aug 4, 2014

Can be overridden by specifying style="width:100%;" in each tag in a NAVBAR that requires a full cell width button. Shouldn't this be the default action?

agador commented Aug 4, 2014

Can be overridden by specifying style="width:100%;" in each tag in a NAVBAR that requires a full cell width button. Shouldn't this be the default action?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 7, 2014

Member

@agador

Thanks for reporting the issue. This is indeed a bug. It's a regression from 1ed6f92. Currently we say the framework makes all buttons inside toolbars default to inline and mini style (we are going to deprecate this behaviour in 1.5: #7574) and this commit was to solve an inconsistency. [edit: However, buttons in navbars shouldn't have been affected by this.] All our navbar examples only contain anchor elements, so this problem with button elements hasn't been noticed.

Member

jaspermdegroot commented Aug 7, 2014

@agador

Thanks for reporting the issue. This is indeed a bug. It's a regression from 1ed6f92. Currently we say the framework makes all buttons inside toolbars default to inline and mini style (we are going to deprecate this behaviour in 1.5: #7574) and this commit was to solve an inconsistency. [edit: However, buttons in navbars shouldn't have been affected by this.] All our navbar examples only contain anchor elements, so this problem with button elements hasn't been noticed.

@jaspermdegroot jaspermdegroot added this to the 1.4.4 milestone Aug 7, 2014

@jaspermdegroot jaspermdegroot self-assigned this Aug 7, 2014

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 7, 2014

Member

@arschmitz

I just noticed there are also issues with navbars with button elements when the navbar is not in a toolbar. In that case the buttons get shadow and corner style.
Is button elements in navbars something we don't support? I didn't see anything about it in the documentation. Although it's meant for navigation (links) I can imagine people want to use a navbar instead of a controlgroup because of it's full width style and grid.

Member

jaspermdegroot commented Aug 7, 2014

@arschmitz

I just noticed there are also issues with navbars with button elements when the navbar is not in a toolbar. In that case the buttons get shadow and corner style.
Is button elements in navbars something we don't support? I didn't see anything about it in the documentation. Although it's meant for navigation (links) I can imagine people want to use a navbar instead of a controlgroup because of it's full width style and grid.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 7, 2014

Member

We just discussed this during our meeting and we do want to support button elements in navbars so we are going to fix this.

Member

jaspermdegroot commented Aug 7, 2014

We just discussed this during our meeting and we do want to support button elements in navbars so we are going to fix this.

@agador

This comment has been minimized.

Show comment
Hide comment
@agador

agador Aug 8, 2014

Thanks for the updates.

Jim

agador commented Aug 8, 2014

Thanks for the updates.

Jim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment