New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos: .ui-btn-left / .ui-btn-right in Toolbar: Footers #7634

Closed
jtsage opened this Issue Aug 20, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@jtsage

jtsage commented Aug 20, 2014

Through much digging, it has become apparent that out-of-the-box, .ui-btn-left and .ui-btn-right are not exactally supported in footers. (At least, they don't have proper padding).

However, this is not mentioned anywhere on the toolbar demo page

Although I would expect it is out-of-scope to discuss custom CSS hacks on the demo site, a word of warning will likely save others some headaches.

Sources of information were:

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 21, 2014

Contributor

We might be able to do a demo showing the custom CSS necessary for making it work in a footer. @jaspermdegroot what do you think?

Contributor

gabrielschulhof commented Aug 21, 2014

We might be able to do a demo showing the custom CSS necessary for making it work in a footer. @jaspermdegroot what do you think?

@jtsage

This comment has been minimized.

Show comment
Hide comment
@jtsage

jtsage Aug 21, 2014

Very cool, thank you for the quick response.

For what it's worth, viewing the demo on a small device - IPhone 4s in this case - very clearly demonstrates the fact that the footer does not take into account the presence of buttons.

photo

jtsage commented Aug 21, 2014

Very cool, thank you for the quick response.

For what it's worth, viewing the demo on a small device - IPhone 4s in this case - very clearly demonstrates the fact that the footer does not take into account the presence of buttons.

photo

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 21, 2014

Contributor

... case in point ...

Contributor

gabrielschulhof commented Aug 21, 2014

... case in point ...

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 25, 2014

Member

As I wrote in my comments at the tickets @jtsage referred to, the ui-btn-left and ui-btn-right are designed for the header only, not for the footer. If we are going to add a demo of using those classes in the footer with some custom CSS for overriding/setting the top and bottom offset, users will get the impression it's a supported feature to use those classes in the footer that way and expect the same results as with headers. The problem with text in footers illustrates that this isn't the case.

If we add a demo of absolutely positioned buttons in a footer I think it's better to only use custom CSS, and not the ui-btn-left and ui-btn-right classes. Other benefit is that things won't break if we make changes in the CSS rules for those classes.

Update: I just saw the PR (#7635) for this ticket. The text above the demo does make clear that users shouldn't expect the same result as with headers. I still think it's better to not use the classes at all.

Member

jaspermdegroot commented Aug 25, 2014

As I wrote in my comments at the tickets @jtsage referred to, the ui-btn-left and ui-btn-right are designed for the header only, not for the footer. If we are going to add a demo of using those classes in the footer with some custom CSS for overriding/setting the top and bottom offset, users will get the impression it's a supported feature to use those classes in the footer that way and expect the same results as with headers. The problem with text in footers illustrates that this isn't the case.

If we add a demo of absolutely positioned buttons in a footer I think it's better to only use custom CSS, and not the ui-btn-left and ui-btn-right classes. Other benefit is that things won't break if we make changes in the CSS rules for those classes.

Update: I just saw the PR (#7635) for this ticket. The text above the demo does make clear that users shouldn't expect the same result as with headers. I still think it's better to not use the classes at all.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Aug 26, 2014

Contributor

@jaspermdegroot, roger that!

Contributor

gabrielschulhof commented Aug 26, 2014

@jaspermdegroot, roger that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment