New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listview: Add classes option #7692

Closed
gabrielschulhof opened this Issue Sep 19, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Sep 19, 2014

No description provided.

@gabrielschulhof gabrielschulhof self-assigned this Sep 19, 2014

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Sep 19, 2014

gabrielschulhof added a commit that referenced this issue Sep 22, 2014

gabrielschulhof added a commit that referenced this issue Oct 1, 2014

gabrielschulhof added a commit that referenced this issue Oct 8, 2014

gabrielschulhof added a commit that referenced this issue Oct 9, 2014

gabrielschulhof added a commit that referenced this issue Oct 16, 2014

gabrielschulhof added a commit that referenced this issue Oct 21, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 1, 2015

Contributor

@jaspermdegroot in css/structure.jquery.mobile.listview.css it says that ui-li-has-icon is deprecated in 1.4.0 and that it should be removed. Well, we no longer add class ui-li-has-icon and ui-li-has-thumb from the listview code, but does that mean we remove the rules associated with them as well?

Contributor

gabrielschulhof commented Feb 1, 2015

@jaspermdegroot in css/structure.jquery.mobile.listview.css it says that ui-li-has-icon is deprecated in 1.4.0 and that it should be removed. Well, we no longer add class ui-li-has-icon and ui-li-has-thumb from the listview code, but does that mean we remove the rules associated with them as well?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 2, 2015

Member

@gabrielschulhof

Yes. CSS for ui-li-has-icon should be removed. We keep the CSS for ui-li-has-thumb.
See http://jquerymobile.com/upgrade-guide/1.4/#images

Member

jaspermdegroot commented Feb 2, 2015

@gabrielschulhof

Yes. CSS for ui-li-has-icon should be removed. We keep the CSS for ui-li-has-thumb.
See http://jquerymobile.com/upgrade-guide/1.4/#images

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Feb 23, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Feb 26, 2015

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 5, 2015

Member

Note: #7670 can be fixed when implementing the classes option.

Member

jaspermdegroot commented Jun 5, 2015

Note: #7670 can be fixed when implementing the classes option.

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jul 9, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jul 14, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jul 15, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jul 16, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jul 17, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Aug 4, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Aug 13, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Aug 28, 2015

gabrielschulhof added a commit that referenced this issue Sep 16, 2015

@arschmitz arschmitz closed this Dec 11, 2015

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment