New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Panels don't render correctly with Fixed Header. #7739

Closed
KpjComp opened this Issue Oct 6, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@KpjComp

KpjComp commented Oct 6, 2014

Using External Panels, as in example -> http://demos.jquerymobile.com/1.4.4/panel-external-internal/

They don't render correctly, if you open the left panel you will notice a thick black band across the bottom of the page, and if you open the right panel you don't get the black band but it does not render to the bottom of the page.

Also I've noticed if you click the body of the page, the footer jumps up and down..

Looking at the size of the black bar, it appears to be twice the size of the header. Using chrome inspector to me it looks like the calculation for min-height is doubling up.

Having this working would be great, as page transitions with a fixed header look really nice.. Eg. The content can be made to slide in & out, and the headers stay fixed.

Tested in latest Chrome / Firefox and IE9, all do the same.

@Ruffio

This comment has been minimized.

Show comment
Hide comment
@Ruffio

Ruffio Oct 6, 2014

I can confirm this.

Also note there is different behavior when selecting a different page. In
the header the selection is only shown briefly while the footer always
shows current page. Try to select a new page both in header and footer and
you will see the difference.

Venlig hilsen Rasmus Christiansen
Den 06/10/2014 18.18 skrev "KpjComp" notifications@github.com:

Using External Panels, as in example ->
http://demos.jquerymobile.com/1.4.4/panel-external-internal/

They don't render correctly, if you open the left panel you will notice a
thick black band across the bottom of the page, and if you open the right
panel you don't get the black band but it does not render to the bottom of
the page.

Also I've noticed if you click the body of the page, the footer jumps up
and down..

Looking at the size of the black bar, it appears to be twice the size of
the header. Using chrome inspector to me it looks like the calculation for
min-height is doubling up.

Having this working would be great, as page transitions with a fixed
header look really nice.. Eg. The content can be made to slide in & out,
and the headers stay fixed.

Tested in latest Chrome / Firefox and IE9, all do the same.


Reply to this email directly or view it on GitHub
#7739.

Ruffio commented Oct 6, 2014

I can confirm this.

Also note there is different behavior when selecting a different page. In
the header the selection is only shown briefly while the footer always
shows current page. Try to select a new page both in header and footer and
you will see the difference.

Venlig hilsen Rasmus Christiansen
Den 06/10/2014 18.18 skrev "KpjComp" notifications@github.com:

Using External Panels, as in example ->
http://demos.jquerymobile.com/1.4.4/panel-external-internal/

They don't render correctly, if you open the left panel you will notice a
thick black band across the bottom of the page, and if you open the right
panel you don't get the black band but it does not render to the bottom of
the page.

Also I've noticed if you click the body of the page, the footer jumps up
and down..

Looking at the size of the black bar, it appears to be twice the size of
the header. Using chrome inspector to me it looks like the calculation for
min-height is doubling up.

Having this working would be great, as page transitions with a fixed
header look really nice.. Eg. The content can be made to slide in & out,
and the headers stay fixed.

Tested in latest Chrome / Firefox and IE9, all do the same.


Reply to this email directly or view it on GitHub
#7739.

@gabrielschulhof gabrielschulhof added this to the 1.4.5 milestone Oct 27, 2014

@gabrielschulhof gabrielschulhof self-assigned this Oct 27, 2014

gabrielschulhof added a commit that referenced this issue Oct 27, 2014

Helpers: resetActivePageHeight() ignores fixed toolbars
Any external fixed toolbar widget with option updatePagePadding set to true
need not be accounted for when calculating page height, because it updates the
page padding to account for itself.

Fixes gh-7739

gabrielschulhof added a commit that referenced this issue Oct 30, 2014

Helpers: resetActivePageHeight() ignores fixed toolbars
Any external fixed toolbar widget with option updatePagePadding set to true
need not be accounted for when calculating page height, because it updates the
page padding to account for itself.

(cherry picked from commit 2060bca)

Closes gh-7802
Fixes gh-7739

agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014

Helpers: resetActivePageHeight() ignores fixed toolbars
Any external fixed toolbar widget with option updatePagePadding set to true
need not be accounted for when calculating page height, because it updates the
page padding to account for itself.

Closes gh-7802
Fixes gh-7739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment