Build: Build script breaks "Classic theme" demo #7771

Closed
jaspermdegroot opened this Issue Oct 10, 2014 · 7 comments

Projects

None yet

5 participants

@jaspermdegroot
Member

See jquery/demos.jquerymobile.com#4 (comment)

The problem is that our build script changes <link rel="stylesheet" href="../../css/structure/jquery.mobile.structure.css"> to <link rel="stylesheet" href="../css/themes/default/jquery.mobile-1.4.4.structure.min.css">.

@jaspermdegroot jaspermdegroot added this to the 1.4.5 milestone Oct 10, 2014
@jaspermdegroot jaspermdegroot referenced this issue in jquery/demos.jquerymobile.com Oct 10, 2014
Closed

Broken pages in demo #4

@imaffett
Contributor

@jaspermdegroot - I'm not too familiar with the build script, but I see in processDemos and demos.backbone it's doing the following

processedName = grunt.config.process( name + "<%= versionSuffix %>" );

I think those should just be the following. Happy to submit a PR with the fix.

processedName = name;
@jaspermdegroot
Member

@imaffett

Thanks for your offer to contribute! I am not too familiar with the build script either, but I think the problem is more this part of the script: https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L147
@gseguin can you chime in here?

@imaffett
Contributor

@jaspermdegroot - What about the script tag above? Should that have the version in it or not?

https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L105
https://github.com/jquery/jquery-mobile/blob/1.4-stable/Gruntfile.js#L109

If that's the case, then the regex can be changed to just use name instead of processedName

@gabrielschulhof
Contributor

@jaspermdegroot spotted it. We shouldn't be using processedName in the concatenation, but grunt.config.process( name + ".structure" + "<?= versionSuffix %>" )

@gabrielschulhof
Contributor

@arschmitz, @gseguin should we maybe add a travis job that runs casper on a versioned copy of dist/. I mean, like, running casper on the demos produced by grunt release:init dist?

@arschmitz
Member

@gabrielschulhof hmm the only thing about that is it takes quite a while to run the casper tests. I will be updating the casper tests shortly to use grunt-spider which allows much better configuration for multiple test runs we can figure something out for testing this then as well. But lets not let that hold up fixing this.

@gabrielschulhof
Contributor

@arschmitz Yeah, that's cool. In fact, we should separate out the casper tests. Running them with every job is kinda superfluous, unless we key in the jQuery version into the casper tests as well.

@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014
@gabrielschulhof @agcolom gabrielschulhof + agcolom Build: Correctly transform structure CSS references in the demos
Closes gh-7778
Fixes gh-7771
08f9e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment