New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.4 Hash processing demo - Buttons stay blue #7775

Closed
Ruffio opened this Issue Oct 13, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@Ruffio

Ruffio commented Oct 13, 2014

Go to http://demos.jquerymobile.com/1.4.4/navigation-hash-processing/
Click on Open Demo.
Click on the buttons (my area - my friends - my items) one by one.
The header changes title as expected but the buttons keep being blue so finally all buttons are blue all the time.

Tested on Nexus 7 Chrome 38.0.2125.102 and iPad 3 iOS 7.12

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Oct 16, 2014

Contributor

This is actually a bit of a sticky issue. We remove the active class from the button, but only if the page is no longer active. When dealing with a same-page transition, the page on which the link can be found is active before and after the transition. We can force the active class to be removed, but we can only do so at the beginning or the end of the transition. If we remove it at the beginning, it will never really be shown on-screen, because it's removed in the same JS frame in which it's added. If, OTOH, we remove it after the transition, in the case of the fade transition it looks like it flashes.

Contributor

gabrielschulhof commented Oct 16, 2014

This is actually a bit of a sticky issue. We remove the active class from the button, but only if the page is no longer active. When dealing with a same-page transition, the page on which the link can be found is active before and after the transition. We can force the active class to be removed, but we can only do so at the beginning or the end of the transition. If we remove it at the beginning, it will never really be shown on-screen, because it's removed in the same JS frame in which it's added. If, OTOH, we remove it after the transition, in the case of the fade transition it looks like it flashes.

@Palestinian

This comment has been minimized.

Show comment
Hide comment

Palestinian commented Oct 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment