New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jquery mobile & Hammer js #7805

Closed
jackyon opened this Issue Oct 29, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@jackyon

jackyon commented Oct 29, 2014

Hi, currently i'm using jquery mobile for building an web app, every thing works great, but i found there is some bugs happened the swipe issues on Android devices.

so I'm using the hammer js to solve those issues, jquery mobile 1.3.2 have no problem working with hammer js, but when I upgrade to version 1.4.4, the swipe event works weird, it is not smooth than before, most of time I need to swipe a lot of times then the swipe event will be trigger

hammer swipe usage: $(element).hammer().on("swipeleft", myFunction);
jquery mobile swipe usage: $(element).on('swipeleft',myFunction);

I think this issue happened because of the element binds multiple events, am I right?

plz advise any solution for this, I have been fighting with this issue couple of days.

thx!

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Oct 29, 2014

Contributor

@arschmitz I was going to suggest to @jackyon building a custom version of jQuery Mobile using the download builder. At that point I discovered a few problems:

  1. The swipe events are inside events/touch, so if you wanna build without them, you need to uncheck events/touch, however this leads to the following problems: navigation.js (because of the vclick handler that adds the active button class) depends on vclick, so on events/touch. Thus, attempting to build without swipe will also remove vclick, which basically removes navigation and init. We might want to split swipe out of events/touch and maybe put it into events/swipe - although I haven't checked if swipe uses internal variables also used by other events inside events/touch.
  2. navigation.js and pagecontainer depends on events.js, not events/touch, events/throttledresize, and events/navigate individually. Thus, we should also update that dependency, and eventually remove events.js entirely, because it's an empty module.
Contributor

gabrielschulhof commented Oct 29, 2014

@arschmitz I was going to suggest to @jackyon building a custom version of jQuery Mobile using the download builder. At that point I discovered a few problems:

  1. The swipe events are inside events/touch, so if you wanna build without them, you need to uncheck events/touch, however this leads to the following problems: navigation.js (because of the vclick handler that adds the active button class) depends on vclick, so on events/touch. Thus, attempting to build without swipe will also remove vclick, which basically removes navigation and init. We might want to split swipe out of events/touch and maybe put it into events/swipe - although I haven't checked if swipe uses internal variables also used by other events inside events/touch.
  2. navigation.js and pagecontainer depends on events.js, not events/touch, events/throttledresize, and events/navigate individually. Thus, we should also update that dependency, and eventually remove events.js entirely, because it's an empty module.
@jackyon

This comment has been minimized.

Show comment
Hide comment
@jackyon

jackyon Nov 20, 2014

@gabrielschulhof , sorry for been so late to see that.

yes, I totally agree with your ideas, it also bother me a lot, the only reason what I impressed of jquery mobile is the navigation(ajax simply) & page transition

I'm consider to give up jquery mobile, did u have other solution for quickly using the ajax&callbacks

plz advise. thx!

jackyon commented Nov 20, 2014

@gabrielschulhof , sorry for been so late to see that.

yes, I totally agree with your ideas, it also bother me a lot, the only reason what I impressed of jquery mobile is the navigation(ajax simply) & page transition

I'm consider to give up jquery mobile, did u have other solution for quickly using the ajax&callbacks

plz advise. thx!

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Nov 20, 2014

Member

@jackyon @gabrielschulhof yeah it looks like we need to sort out some dependency issues here so that can be excluded we will have to make sure we do this before 1.5

Member

arschmitz commented Nov 20, 2014

@jackyon @gabrielschulhof yeah it looks like we need to sort out some dependency issues here so that can be excluded we will have to make sure we do this before 1.5

@arschmitz arschmitz added this to the 1.5.0 milestone Nov 20, 2014

@gabrielschulhof gabrielschulhof self-assigned this Dec 16, 2014

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Dec 19, 2014

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Dec 19, 2014

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Dec 29, 2014

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 19, 2015

Build: Include events.js from jquery.mobile.js
events.js was making it into the build only by virtue of the fact that it was
being pulled by navigation.js. In the process of fixing jquerygh-7805 it became clear
that navigation.js doesn't really need events.js. Thus, the reference to
events.js was removed from navigation.js, thereby orphaning events.js from the
build. This rectifies the problem by explicitly adding events.js to the build.

Fixes jquerygh-7925

gabrielschulhof added a commit that referenced this issue Apr 2, 2015

Build: Include events.js from jquery.mobile.js
events.js was making it into the build only by virtue of the fact that it was
being pulled by navigation.js. In the process of fixing gh-7805 it became clear
that navigation.js doesn't really need events.js. Thus, the reference to
events.js was removed from navigation.js, thereby orphaning events.js from the
build. This rectifies the problem by explicitly adding events.js to the build.

Fixes gh-7925
Closes gh-7926

kakul added a commit to kakul/jquery-mobile that referenced this issue Apr 14, 2015

Build: Include events.js from jquery.mobile.js
events.js was making it into the build only by virtue of the fact that it was
being pulled by navigation.js. In the process of fixing jquerygh-7805 it became clear
that navigation.js doesn't really need events.js. Thus, the reference to
events.js was removed from navigation.js, thereby orphaning events.js from the
build. This rectifies the problem by explicitly adding events.js to the build.

Fixes jquerygh-7925
Closes jquerygh-7926
@celron

This comment has been minimized.

Show comment
Hide comment
@celron

celron Sep 28, 2015

Greetings @arschmitz I believe that am running into this issue #7805 with jquery mobile 1.4.5. I see that this is fixed, however I'm not sure what version this is fixed in (is it 1.4.5 or is it in the forthcoming 1.5?) or otherwise implement the fix on my own which I think is to pull out event.js or is it include it?

Thanks!

celron commented Sep 28, 2015

Greetings @arschmitz I believe that am running into this issue #7805 with jquery mobile 1.4.5. I see that this is fixed, however I'm not sure what version this is fixed in (is it 1.4.5 or is it in the forthcoming 1.5?) or otherwise implement the fix on my own which I think is to pull out event.js or is it include it?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment