New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini slider is broken in 1.4.5 #7821

Closed
slavap opened this Issue Nov 3, 2014 · 7 comments

Comments

Projects
None yet
7 participants
@slavap

slavap commented Nov 3, 2014

Test case: http://jsbin.com/zuyapirepi/1/edit
Workaround: .ui-slider-track.ui-mini { margin: 0 15px 0 68px; }

Originally reported here: https://plus.google.com/105587967205913541400/posts/4DQVj3o5xYE
It's also broken on official demo page: http://demos.jquerymobile.com/1.4.5/slider/

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Nov 3, 2014

Member

I was going to report the exact same issue! So I can confirm the problem. The track comes over the input field. Tested on Chrome, Safari and Firefox.

Member

agcolom commented Nov 3, 2014

I was going to report the exact same issue! So I can confirm the problem. The track comes over the input field. Tested on Chrome, Safari and Firefox.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Nov 3, 2014

Member

This is a regression from ab067cb

Member

arschmitz commented Nov 3, 2014

This is a regression from ab067cb

ldeluca added a commit to ldeluca/jquery-mobile that referenced this issue Nov 4, 2014

Forms: fixes regression bug from ui-mini fix.
slider no longer over input field.

Fixes #7821

slavap added a commit to jqm4gwt/jqm4gwt that referenced this issue Nov 4, 2014

@denesl

This comment has been minimized.

Show comment
Hide comment
@denesl

denesl Nov 18, 2014

ONLY for older slider based switches.
The workaround "breaks" the margins of the flip switch. To fix add:
margin: .5em 0;
to
div.ui-slider-switch.ui-mini

denesl commented Nov 18, 2014

ONLY for older slider based switches.
The workaround "breaks" the margins of the flip switch. To fix add:
margin: .5em 0;
to
div.ui-slider-switch.ui-mini

@tjelka

This comment has been minimized.

Show comment
Hide comment
@tjelka

tjelka Dec 23, 2014

This fix also brakes rangeslider, then it's too small, too big left margin for rangeslider with this fix. When you put slider and range slider on same page in 1.4.5 and after applying this fix is not ok.

tjelka commented Dec 23, 2014

This fix also brakes rangeslider, then it's too small, too big left margin for rangeslider with this fix. When you put slider and range slider on same page in 1.4.5 and after applying this fix is not ok.

@slavap

This comment has been minimized.

Show comment
Hide comment
@slavap

slavap Dec 23, 2014

@tjelka
I don't see any problem with rangeslider. Look here: http://jsbin.com/yozibiriho/1/edit
So this fix is working:

.ui-slider-track.ui-mini {
  margin: 0 15px 0 68px;
}
div.ui-slider-switch.ui-mini {
  margin: .5em 0; 
}

slavap commented Dec 23, 2014

@tjelka
I don't see any problem with rangeslider. Look here: http://jsbin.com/yozibiriho/1/edit
So this fix is working:

.ui-slider-track.ui-mini {
  margin: 0 15px 0 68px;
}
div.ui-slider-switch.ui-mini {
  margin: .5em 0; 
}
@Chez

This comment has been minimized.

Show comment
Hide comment
@Chez

Chez Dec 24, 2014

I just noticed this today, can anyone confirm a concrete fix for this please?

Chez commented Dec 24, 2014

I just noticed this today, can anyone confirm a concrete fix for this please?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Mar 19, 2015

Member

This is a regression from commit ab067cb. There is a PR for reverting that commit: #7999
There is another ticket for this issue, which describes all problems (#7991) so I am going to close this ticket as duplicate.

Member

jaspermdegroot commented Mar 19, 2015

This is a regression from commit ab067cb. There is a PR for reverting that commit: #7999
There is another ticket for this issue, which describes all problems (#7991) so I am going to close this ticket as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment