New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dissmissible option not working through panel api #7882

Closed
jerid101 opened this Issue Dec 22, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@jerid101

jerid101 commented Dec 22, 2014

From the panel api: http://api.jquerymobile.com/panel/#option-dismissible

I have tried to set the dismissible option after initialization on both predefined and dynamic panel elements using the default way as indicated in the api.

At first I thought I was doing something wrong, but now after further testing it seems like a bug:

In both cases upon initializing dismissible:

<div data-role="panel" data-dismissible="true">

</div>

Or:

$( ".selector" ).panel({
    dismissible: true
});

The getter works fine:

var dismissible = $( ".selector" ).panel( "option", "dismissible" );

The setter sets the value (and the getter picks up changed value), but the panel has no further effect:

$( ".selector" ).panel( "option", "dismissible", false );

Unless this is not supposed to work this way as all other options I've been able to change to this point.

I have tried this in newest version of jQuery Mobile 1.4, including 1.4.4 and 1.4.5.

Related thread: http://stackoverflow.com/questions/27607605/dissmissible-option-not-working-through-panel-api?noredirect=1#comment43638313_27607605

@Palestinian

This comment has been minimized.

Show comment
Hide comment
@Palestinian

Palestinian Dec 22, 2014

The fix is to check whether dismissible is true before adding dimissible classes to dismissble div upon opening the panel.

Palestinian commented Dec 22, 2014

The fix is to check whether dismissible is true before adding dimissible classes to dismissble div upon opening the panel.

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Dec 30, 2014

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Dec 30, 2014

@gabrielschulhof gabrielschulhof self-assigned this Dec 30, 2014

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Dec 30, 2014

Contributor

This is a duplicate of #7884, and is fixed by #7890.

Contributor

gabrielschulhof commented Dec 30, 2014

This is a duplicate of #7884, and is fixed by #7890.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment