New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar without links #7909

Closed
zimi-pl opened this Issue Jan 9, 2015 · 2 comments

Comments

Projects
None yet
4 participants
@zimi-pl

zimi-pl commented Jan 9, 2015

I had an issue with navbar. Links for this component was generated from my backend and when I tried to generate new page for my application I forget to declare navigation links for it.

When in navbar there is no link it fails to load page. And console is not very helpful. It's not idiot-proof. In fact it was not trivial for me to debug what's happening. It could more helpful, for example with appropriate error "There is no link for navbar! idiot!"... :P

Example: http://jsfiddle.net/9sbm3942/1/

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jan 9, 2015

Member

@zimi-pi i agree this should either work and load just with no links or throw a proper error

Member

arschmitz commented Jan 9, 2015

@zimi-pi i agree this should either work and load just with no links or throw a proper error

@arschmitz arschmitz added this to the 1.5.0 milestone Jan 9, 2015

@cgack cgack referenced this issue Jan 9, 2015

Closed

Navbar Review #7359

0 of 12 tasks complete
@apsdehal

This comment has been minimized.

Show comment
Hide comment
@apsdehal

apsdehal May 8, 2016

Member

Fixed in 1.5-dev.

Member

apsdehal commented May 8, 2016

Fixed in 1.5-dev.

@apsdehal apsdehal closed this May 8, 2016

@apsdehal apsdehal self-assigned this Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment