New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to visibility:hidden instead of display none for inactive pages #8137

Closed
jaspermdegroot opened this Issue May 21, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@jaspermdegroot
Member

jaspermdegroot commented May 21, 2015

No description provided.

@jaspermdegroot jaspermdegroot self-assigned this May 21, 2015

@jaspermdegroot jaspermdegroot changed the title from Investigate using visibility hidden instead of display non for inactive pages to Investigate using visibility hidden instead of display none for inactive pages May 21, 2015

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jul 23, 2015

Member

Something else to consider here is opacity:0 where as toggling display or visibility triggers a layout and repaint an opacity change only repaints that element. However elements with opacity:0 still receive events where as visibility:none do not. I cant think of a case where this would be an issue but something to keep in mind.

Member

arschmitz commented Jul 23, 2015

Something else to consider here is opacity:0 where as toggling display or visibility triggers a layout and repaint an opacity change only repaints that element. However elements with opacity:0 still receive events where as visibility:none do not. I cant think of a case where this would be an issue but something to keep in mind.

@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Jul 23, 2015

@jaspermdegroot jaspermdegroot changed the title from Investigate using visibility hidden instead of display none for inactive pages to Change to opacity 0 instead of display none for inactive pages Jul 26, 2015

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot
Member

jaspermdegroot commented Jul 26, 2015

PR: #8241

arschmitz added a commit that referenced this issue Jul 30, 2015

Page: Use visibility:hidden instead of display:none to hide page
Avoiding display: none means we can calculate heights before transitions
This means less visual update after the end of the transition
and removes the need for binding to pageshow for page layout updates
this also has a small performance benefit since it avoids reflows

Closes gh-8241
Fixes gh-8137
@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jul 30, 2015

Member

switching this to be for using visibility:hidden we cant use opacity because things in inactive pages will still be tabbable

Member

arschmitz commented Jul 30, 2015

switching this to be for using visibility:hidden we cant use opacity because things in inactive pages will still be tabbable

@arschmitz arschmitz changed the title from Change to opacity 0 instead of display none for inactive pages to Change to visibility:hidden instead of display none for inactive pages Jul 30, 2015

arschmitz added a commit that referenced this issue Mar 26, 2016

Page: Use visibility:hidden instead of display:none to hide page
Avoiding display: none means we can calculate heights before transitions
This means less visual update after the end of the transition
and removes the need for binding to pageshow for page layout updates
this also has a small performance benefit since it avoids reflows

Closes gh-8241
Fixes gh-8137

@apsdehal apsdehal closed this May 8, 2016

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

Page: Use visibility:hidden instead of display:none to hide page
Avoiding display: none means we can calculate heights before transitions
This means less visual update after the end of the transition
and removes the need for binding to pageshow for page layout updates
this also has a small performance benefit since it avoids reflows

Closes gh-8241
Fixes gh-8137

@apsdehal apsdehal self-assigned this Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment