New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: ui-link must not be added anymore #8194

Closed
gabrielschulhof opened this Issue Jul 15, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Jul 15, 2015

The code at the top of js/widgets/popup.js adds the class ui-link to some anchors. It

a) does so incorrectly, because there's an extra .end() in the chain, and
b) shouldn't be doing it at all, because ui-link was deprecated and should be removed.

This issue reminds that the code adding ui-link should be removed.

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Jul 15, 2015

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 15, 2015

Member

To avoid confusion; we only deprecated the adding of class ui-link. The CSS for that class remains. If you want to apply the style you can add the class to your markup.

The file js/links.js should be removed as well.

Member

jaspermdegroot commented Jul 15, 2015

To avoid confusion; we only deprecated the adding of class ui-link. The CSS for that class remains. If you want to apply the style you can add the class to your markup.

The file js/links.js should be removed as well.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Jul 25, 2015

Contributor

590df65 removes the code that adds ui-link to popup links. The file js/links.js still needs to be removed.

Contributor

gabrielschulhof commented Jul 25, 2015

590df65 removes the code that adds ui-link to popup links. The file js/links.js still needs to be removed.

@gabrielschulhof gabrielschulhof self-assigned this Jul 25, 2015

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jul 26, 2015

@apsdehal apsdehal closed this May 8, 2016

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

@apsdehal apsdehal self-assigned this Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment