New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog should get ui-body-inherit class if no theme has been specified #8260

Closed
jaspermdegroot opened this Issue Aug 6, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@jaspermdegroot
Member

jaspermdegroot commented Aug 6, 2015

The dialog container should get class ui-body-inherit if no theme has been specified. The same as we do for popups.

The "Custom Overlay Swatch" demo illustrates the problem now it doesn't get this class: http://view.jquerymobile.com/master/demos/pages-dialog/#Stylingtheming

Update: It turns out that we never add a theme class to the dialog container. If a theme has been specified the ui-body-* class should be added to the dialog container, else the ui-body-inherit class.

@jaspermdegroot jaspermdegroot self-assigned this Aug 6, 2015

@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Aug 6, 2015

@jaspermdegroot jaspermdegroot removed their assignment Aug 13, 2015

@jaspermdegroot jaspermdegroot self-assigned this May 12, 2016

apsdehal added a commit to apsdehal/jquery-mobile that referenced this issue Jun 20, 2016

apsdehal added a commit that referenced this issue Jun 23, 2016

@apsdehal apsdehal closed this Jun 23, 2016

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

arschmitz added a commit that referenced this issue Jul 4, 2016

@apsdehal apsdehal self-assigned this Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment