New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5-dev Panel: Page scrolls to top after closing a panel. #8323

Closed
jaspermdegroot opened this Issue Nov 5, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jaspermdegroot
Member

jaspermdegroot commented Nov 5, 2015

When you open a panel, scroll down, and then close the panel, the page scrolls to top. This was not the case in 1.4.5.

Test page: http://view.jquerymobile.com/1.5-dev/demos/panel/
For comparison: http://demos.jquerymobile.com/1.4.5/panel/

Tested on Chrome 46 on OS X.

This is also the cause of the problem with the Quick Links in our demos. Clicking the link makes the page scroll to the section, but because the panel closes at the same time the page immediately jumps back to the top.

@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Nov 5, 2015

@jaspermdegroot jaspermdegroot referenced this issue Nov 5, 2015

Open

1.5 Demos: various issues #8245

21 of 37 tasks complete
@cgack

This comment has been minimized.

Show comment
Hide comment
@cgack

cgack Nov 5, 2015

Contributor

@jaspermdegroot this looks like it was added with gh-6767 landing after the 1.4.5 release. Perhaps we should evaluate what we really want to happen here if this isn't desired.

Contributor

cgack commented Nov 5, 2015

@jaspermdegroot this looks like it was added with gh-6767 landing after the 1.4.5 release. Perhaps we should evaluate what we really want to happen here if this isn't desired.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Nov 5, 2015

Member

Ah you're right @cgack. I never noticed that ticket. Thanks!
I agree we should discuss this. I think we should only scroll to top if ui-content is out of view.
Will comment on that ticket and re-open it for discussion.

Member

jaspermdegroot commented Nov 5, 2015

Ah you're right @cgack. I never noticed that ticket. Thanks!
I agree we should discuss this. I think we should only scroll to top if ui-content is out of view.
Will comment on that ticket and re-open it for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment