New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5-dev Panel: Toolbars don't transition together with content anymore #8324

Closed
jaspermdegroot opened this Issue Nov 9, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@jaspermdegroot
Member

jaspermdegroot commented Nov 9, 2015

When opening/closing reveal and push panels, the header and footer don't transition together with the content anymore. I suppose this is because changes in the toolbar widget haven't been applied yet to the panel widget.

Test page: http://view.jquerymobile.com/1.5-dev/demos/panel/

@cgack

This comment has been minimized.

Show comment
Hide comment
@cgack

cgack Dec 17, 2015

Contributor

making a note for my future self... these selectors should be changed here: https://github.com/jquery/jquery-mobile/blob/master/js/widgets/panel.js#L107-L124

Contributor

cgack commented Dec 17, 2015

making a note for my future self... these selectors should be changed here: https://github.com/jquery/jquery-mobile/blob/master/js/widgets/panel.js#L107-L124

@cgack

This comment has been minimized.

Show comment
Hide comment
@cgack

cgack Mar 3, 2016

Contributor

It looks as though ui-toolbar-header isn't set by the time we are wrapping the content in ui-panel-wrapper, this is causing the headers to remain unwrapped. continuing to investigate

Contributor

cgack commented Mar 3, 2016

It looks as though ui-toolbar-header isn't set by the time we are wrapping the content in ui-panel-wrapper, this is causing the headers to remain unwrapped. continuing to investigate

cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 8, 2016

cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 24, 2016

Panel: Transition with new toolbars
add mobile namespace

Fixes gh-8324

arschmitz added a commit that referenced this issue Mar 26, 2016

@cgack

This comment has been minimized.

Show comment
Hide comment
@cgack

cgack May 19, 2016

Contributor

Closed via gh-8397

Contributor

cgack commented May 19, 2016

Closed via gh-8397

@cgack cgack closed this May 19, 2016

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment