New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core CSS: There is no space between the button text and the icon, if the icon is floatbeginning/floatend #8422

Closed
gabrielschulhof opened this Issue Apr 7, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Apr 7, 2016

@jaspermdegroot wrote in #8309:

There also seems to be a problem with the arrow icon in the button. Can you tell me what I'm doing wrong?

I suppose you mean the lack of space between text and icon? Since we make the icon float with class ui-widget-icon-floatend we will have to add extra padding to the button. Maybe we should do that in core/button CSS, not in selectmenu CSS. Will look into that.

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Apr 7, 2016

@jaspermdegroot jaspermdegroot self-assigned this Apr 7, 2016

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 14, 2016

Member

Actually we don't have to add padding to the button, but margin to the icon. I had absolute positioning of the icon (like we used to this) in my mind when I wrote that. Will add the margin.

Member

jaspermdegroot commented Apr 14, 2016

Actually we don't have to add padding to the button, but margin to the icon. I had absolute positioning of the icon (like we used to this) in my mind when I wrote that. Will add the margin.

jaspermdegroot added a commit that referenced this issue Apr 14, 2016

jaspermdegroot added a commit that referenced this issue Apr 21, 2016

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 21, 2016

Member

Fixed in 1.5-dev. Closing.

Member

jaspermdegroot commented Apr 21, 2016

Fixed in 1.5-dev. Closing.

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Jul 4, 2016

arschmitz added a commit that referenced this issue Jul 4, 2016

@apsdehal apsdehal assigned apsdehal and unassigned apsdehal Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment