New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons in nested listviews don't work (issue #1486) #1489

Merged
merged 2 commits into from Jun 17, 2011

Conversation

Projects
None yet
3 participants
@bernharduw
Contributor

bernharduw commented Apr 20, 2011

I provided an example here: http://jsbin.com/ukewu3/6

@bernharduw

This comment has been minimized.

Show comment
Hide comment
@bernharduw

bernharduw Apr 20, 2011

Owner

This prevents form elements from being incorrectly styled in nested listviews,

Owner

bernharduw commented on js/jquery.mobile.listview.js in b2ff26b Apr 20, 2011

This prevents form elements from being incorrectly styled in nested listviews,

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Apr 28, 2011

Good one, but I think it would be more specific as:

item.add( item.children( ".ui-btn-inner" ) ).addClass( itemClass );

agree? mind making that edit?

scottjehl replied Apr 28, 2011

Good one, but I think it would be more specific as:

item.add( item.children( ".ui-btn-inner" ) ).addClass( itemClass );

agree? mind making that edit?

This comment has been minimized.

Show comment
Hide comment
@bernharduw

bernharduw Apr 28, 2011

Owner

Sure - thanks!

Owner

bernharduw replied Apr 28, 2011

Sure - thanks!

@StevenBlack

This comment has been minimized.

Show comment
Hide comment
@StevenBlack

StevenBlack Jun 1, 2011

Contributor

This pull request appears all-good. Has this fallen through the cracks?

Contributor

StevenBlack commented Jun 1, 2011

This pull request appears all-good. Has this fallen through the cracks?

scottjehl pushed a commit that referenced this pull request Jun 17, 2011

Scott Jehl
Merge pull request #1489 from bernharduw/master
Radio buttons in nested listviews don't work. Fixes #1486

@scottjehl scottjehl merged commit 0cff633 into jquery:master Jun 17, 2011

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jun 17, 2011

Contributor

Landed. Thank you!

Contributor

scottjehl commented Jun 17, 2011

Landed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment