Navbar: data-iconpos is ignored #1797 #1858

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@pravinkmrr

NOTE: this may simply be a documentation bug - data-iconpos works on the navbar element itself.

Navbar: data-iconpos is ignored bug fixed in navbar plugin

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jun 20, 2011

Contributor

I think this is more of a documentation problem. On navbars, iconPos is set data-attributes on the navbar element, because the position is shared across the set. I just verified that that is working fine still. Does that work for you? I can update the docs...

Contributor

scottjehl commented Jun 20, 2011

I think this is more of a documentation problem. On navbars, iconPos is set data-attributes on the navbar element, because the position is shared across the set. I just verified that that is working fine still. Does that work for you? I can update the docs...

@pravinkmrr

This comment has been minimized.

Show comment
Hide comment
@pravinkmrr

pravinkmrr Jun 20, 2011

may be. but i changed the script to use top,bottom,right,left as well as notext for data-iconpos...

may be. but i changed the script to use top,bottom,right,left as well as notext for data-iconpos...

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Jun 20, 2011

Contributor

Okay. Do any of those properties not work currently on the navbar element? Just want to make sure we fix this bug in the right place. Thanks!

Contributor

scottjehl commented Jun 20, 2011

Okay. Do any of those properties not work currently on the navbar element? Just want to make sure we fix this bug in the right place. Thanks!

@pravinkmrr

This comment has been minimized.

Show comment
Hide comment
@pravinkmrr

pravinkmrr Jun 21, 2011

Okay. Hope i will support.

Okay. Hope i will support.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Aug 7, 2011

Contributor

I'm not sure I understand where this was left off. Does this work already? Do the docs need to be updated?

Contributor

toddparker commented Aug 7, 2011

I'm not sure I understand where this was left off. Does this work already? Do the docs need to be updated?

@ahutch

This comment has been minimized.

Show comment
Hide comment
@ahutch

ahutch Oct 1, 2011

The doc still says : "Icons can be stacked above the labels by adding the data-iconpos="top" attribute to each anchor."

However data-iconpos=".." only works when placed in the container that has data-role="navbar"

I wish that the behavior was that of the document. That way I could pick the position per anchor. Left for the button on the left and right for the button on the right.

ahutch commented Oct 1, 2011

The doc still says : "Icons can be stacked above the labels by adding the data-iconpos="top" attribute to each anchor."

However data-iconpos=".." only works when placed in the container that has data-role="navbar"

I wish that the behavior was that of the document. That way I could pick the position per anchor. Left for the button on the left and right for the button on the right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment