Added support for data-filter and data-filter-placeholder on regular... #3480

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

adaptabi commented Jan 24, 2012

...selects when data-native-menu="false"

Member

gseguin commented Jan 25, 2012

Thank you for the pull request. Do you have tests for this? or a jsbin showing the feature?

Also, this seems to contain not only the feature in the title but also some refactoring (string concat). Could you split that commit into smaller commits as it makes it easier to track bugs.

Contributor

adaptabi commented Jan 26, 2012

Sorry, I am on the holiday for the next two weeks. Good luck with the changes :)

Contributor

adaptabi commented Feb 7, 2012

All good?

Contributor

johnbender commented Apr 6, 2012

@dotnetwise

For a change this large we'd normally ask you to write some tests. There's test suite at /tests/unit/select/ that you can start at. Otherwise it's going to be a while before we get to it since we have to make sure everything is working as expected.

Contributor

toddparker commented May 5, 2012

@dotnetwise - have you had a chance to look at writing tests for this? Seems like a cool feature, but we do need to have good test coverage to pull this in. Appreciate the contribution!

Contributor

johnbender commented May 14, 2012

Closing due to inactivity.

@johnbender johnbender closed this May 14, 2012

npmcomponent pushed a commit to npmcomponent/cbou-jquery-mobile that referenced this pull request Jan 8, 2014

The button's text should preserve the original css class of the selec…
…t and the selected option. This way you can customize it with i.e. images.


This change is along with this one: jquery/jquery-mobile#3480 (commits)

For a demo: http://www.dotnetwise.com/tryAndError/jquery.mobile/select.filter/

nitinthakare pushed a commit to nitinthakare/tcs that referenced this pull request Jan 7, 2015

The button's text should preserve the original css class of the selec…
…t and the selected option. This way you can customize it with i.e. images.

This change is along with this one: jquery/jquery-mobile#3480 (commits)

For a demo: http://www.dotnetwise.com/tryAndError/jquery.mobile/select.filter/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment