New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible adds top, bottom corner classes to all .ui-btn-inner elements #3661

Merged
merged 1 commit into from Mar 2, 2012

Conversation

Projects
None yet
3 participants
@jasonlcrane
Contributor

jasonlcrane commented Feb 28, 2012

Creating a collapsible widget adds "ui-corner-top" and "ui-corner-bottom" classes to all "ui-btn-inner" elements in the DOM, rather than just to the collapsible header. Setting the context for which ui-btn-inner to change the class on fixes the problem for me.

Example with 1.0.1: http://jsbin.com/ucijek/4
"Collapsible" in the navbar opens a page with collapsible widgets. When you return to the first page, the corners on the navbar buttons are rounded.

Example with the fix: http://jsbin.com/odexog/2

@ghost ghost assigned gseguin Feb 28, 2012

scottjehl pushed a commit that referenced this pull request Mar 2, 2012

Scott Jehl
Merge pull request #3661 from jasonlcrane/collapsible-corner-classes-fix
Collapsible adds top, bottom corner classes to all .ui-btn-inner elements

@scottjehl scottjehl merged commit 2a15f18 into jquery:master Mar 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment