Custom collapsible icons #3821

Merged
merged 4 commits into from Apr 18, 2012

Projects

None yet

4 participants

Contributor

Adds the ability to change the icon used for collapsible headers through data-* attributes and prototype options. Also includes documentation and tests.

Contributor
Wilto commented Mar 15, 2012

Code, documentation, and tests? This, sir, is how pull requests are done. Great work.

Contributor

Thanks! I'm new to qUnit and js testing in general so I thought this would be a good opportunity to get my feet wet.

Contributor

@toddparker, any chance this makes it into 1.1.1? I've got a use case and would rather not wait for 1.2 or custom build. Nothing critical but would be nice to have.

Contributor

This is a nice feature, but for a maintenance release I don't think we'd add a feature or change the API like this. I would like to add this for 1.2 for sure.

@gseguin gseguin merged commit 3713010 into jquery:master Apr 18, 2012
Contributor

@jakeboone02 this is now in master and queued for 1.2 (thanks @gseguin). Excellent work here, really appreciate your work on this.

Contributor

Thanks! Glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment