Update docs/api/data-attributes.html #4049

Merged
merged 3 commits into from Apr 16, 2012

Conversation

Projects
None yet
3 participants
Member

agcolom commented Apr 15, 2012

Added none as option to Select data-icon. Fixes #4028
Tested by @MauriceG: http://jsfiddle.net/MauriceG/BGuCW/2/

Contributor

MauriceG commented Apr 15, 2012

There she is :-)

But it is not none it is data-icon='false'

Owner

agcolom commented on 7fc6149 Apr 15, 2012

had none intead of false! Thank you @MauriceG :-)

Contributor

MauriceG commented Apr 15, 2012

Setting the data-icon attribute to "false" is handled as a false boolean-value inside the button-markup-function.
Setting the attribute like data-icon="0" or data-icon="" has the same result.
Tested with Safari 5.1.4 on Win7, Safari on iPad 3 and iPhone 4S iOS 5.1, Firefox 7.0.1 + 11.0 on Win7.
May other browsers have different results.

Owner

agcolom commented on 3ddf97f Apr 16, 2012

changed the default iconpos: navbar: top, select: right and arrow-d

@toddparker toddparker added a commit that referenced this pull request Apr 16, 2012

@toddparker toddparker Merge pull request #4049 from agcolom/patch-68
Update docs/api/data-attributes.html [docs 1.1.1.]
738b056

@toddparker toddparker merged commit 738b056 into jquery:master Apr 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment