Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[navigation] When showing a dialog, do not append dialogHashKey if the U... #4073

Merged
merged 1 commit into from

2 participants

@gabrielschulhof
Collaborator

...RL already contains it - Fixes: #2656

@gseguin gseguin was assigned
@gseguin gseguin merged commit d3d1417 into jquery:master
@gseguin gseguin referenced this pull request from a commit
@gseguin gseguin Revert "Merge pull request #4073 from gabrielschulhof/fix-dialog-doub…
…le-hash"

This reverts commit 379ba6d.
49155c2
@gseguin gseguin referenced this pull request from a commit
@gseguin gseguin Revert "Merge pull request #4073 from gabrielschulhof/fix-dialog-doub…
…le-hash"

This reverts commit d3d1417, reversing
changes made to 28407c9.
35d954d
@gabrielschulhof
Collaborator

Did this solution cause some unexpected problems?

@gabrielschulhof
Collaborator

OK, I see now.

"going back from a dialog triggered from a dialog should result in the first dialog"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 17, 2012
  1. @gabrielschulhof

    [navigation] When showing a dialog, do not append dialogHashKey if th…

    gabrielschulhof authored
    …e URL already contains it - Fixes: #2656
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  js/jquery.mobile.navigation.js
View
2  js/jquery.mobile.navigation.js
@@ -1042,7 +1042,7 @@ define( [
// be an empty string. Moving the undefined -> empty string back into
// urlHistory.addNew seemed imprudent given undefined better represents
// the url state
- url = ( active.url || "" ) + dialogHashKey;
+ url = ( active.url || "" ).replace(dialogHashKey, "") + dialogHashKey;
}
// Set the location hash.
Something went wrong with that request. Please try again.