Skip to content

Dialog: Make the dialog corners-markup unbreakable #4290

Closed
wants to merge 2 commits into from

3 participants

@MauriceG
MauriceG commented May 4, 2012

Addresses #4277 : ignore all tags between header/content content/footer when adding ui-corner classes to a dialog

@johnbender

@Wilto @scottjehl

Can one of you take a look at this?

@jaspermdegroot
jQuery Foundation member

I had a look at this and my conclusion is we can't merge it.
Reason is that JQM's header, content and footer are conventions but not requirements.
Wouldn't .children( ':first-child').not("script") solve the issue?

@jaspermdegroot
jQuery Foundation member

@MauriceG

Looks like I accidently deleted the beginning of my comment. That was...

Hi Maurice, Thanks for looking into the issue and the suggested fix!

(an important part because now it all sounds a bit ungrateful, sorry)

@MauriceG

mmh. If a dialog has no header/content/footer containers, this PR will not change any of its styling.
It just ignores any tags between each other and works just fine in my local repo.

@jaspermdegroot
jQuery Foundation member

@MauriceG - Yes, but no corner stylling gets applied either, right? Example: http://jsbin.com/ojeyon/4/ [update: to be clear, the example loads current code]

@MauriceG

I see a photo with corners.

May this shows, what i mean:
Without the PR http://jsfiddle.net/MauriceG/ZTKby/
with PR http://jsfiddle.net/MauriceG/ZTKby/2/

and no header, no content container with PR: http://jsfiddle.net/MauriceG/ZTKby/3/

@jaspermdegroot
jQuery Foundation member

@MauriceG

From those 3 only the first one is correct, because we want to apply border radius to all 4 corners at the outside of the dialog.

@MauriceG

Okay. Now I've got you.
But for me the header should get the round corners. Not any tag before it.
So leave this as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.