Text on disabled buttons should not be selectable #4373

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@MauriceG
Contributor
@jaspermdegroot
Member

@scottjehl @Wilto

This has been done for checkbox/radio labels as well by @jasondscott. (5d5e818)
Are there more button types where we should disable user-select? For instance selectmenu.
Should @MauriceG his change go in the theme.css or in structure (button.css)? Maybe we can limit it to one rule with a bunch of selectors.

@toddparker
Contributor

+1 for changing this for anything with button markup. @MauriceG - mind re-working?

@toddparker toddparker closed this May 24, 2012
@jaspermdegroot
Member

@toddparker - That includes list items. Text in those should still be selectable.

@MauriceG
Contributor

Hi @uGoMobi
What is including list items?
And: Text on list items with links should be selectable?
Maurice

@jaspermdegroot
Member

Hi @MauriceG

Sorry, I should have been more clear.
Anything with button markup means listview buttons as well. I don't think we should set user-select to none for buttons in a list. Mostly because of read-only lists and list with formatted text, but even a basic linked list could contain information you want to select.

@MauriceG
Contributor

@uGoMobi
With Safari on windows I'm unable to select any text in a listview with links eg: http://jquerymobile.com/test/docs/lists/lists-formatting.html

@jaspermdegroot
Member

@MauriceG

You can't select a specific part of the text, but when you start with mousedown outside the list item you can select the text.
Anyway, I am just suggesting to not set user-select none as a default for listview buttons. Not saying we have to improve the selectability.

BTW - Read-only lists are currently not buttons, but will have button class as from 1.2.

@MauriceG
Contributor

@uGoMobi
I've no mouse on my mobile devices ;-)
I was wondering about read only lists are buttons.
Will they look like buttons in 1.2 or be buttons without function?

@jaspermdegroot
Member

@MauriceG

I saw your new PR. Read-only lists don't get ui-btn-text, only ui-btn-up-x for styling so that won't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment