Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixes issue #4114 - mini listview not supported #4464

Merged
merged 1 commit into from

2 participants

@jaspermdegroot
Collaborator

As discussed at #4114 we are not supporting data-mini="true" on listviews.
This commit removes the option from the JS. No changes in CSS needed.

@toddparker

So this just removes the mini option and will ignore the attribute if set on a list, right? If so, you can commit this to master and cherry pick to 1.1-stable.

@jaspermdegroot
Collaborator

That's correct.

@jaspermdegroot jaspermdegroot merged commit f373a90 into jquery:master
@jaspermdegroot jaspermdegroot referenced this pull request from a commit
@jaspermdegroot jaspermdegroot Revert "Merge pull request #4464 from uGoMobi/issue_#4114"
This reverts commit f373a90, reversing
changes made to a2a2b36.
83359a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 28, 2012
  1. @jaspermdegroot
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  js/jquery.mobile.listview.js
View
2  js/jquery.mobile.listview.js
@@ -23,7 +23,6 @@ $.widget( "mobile.listview", $.mobile.widget, {
dividerTheme: "b",
splitIcon: "arrow-r",
splitTheme: "b",
- mini: false,
inset: false,
initSelector: ":jqmData(role='listview')"
},
@@ -33,7 +32,6 @@ $.widget( "mobile.listview", $.mobile.widget, {
listviewClasses = "";
listviewClasses += t.options.inset ? " ui-listview-inset ui-corner-all ui-shadow " : "";
- listviewClasses += t.element.jqmData( "mini" ) || t.options.mini === true ? " ui-mini" : "";
// create listview markup
t.element.addClass(function( i, orig ) {
Something went wrong with that request. Please try again.