if you have a moment, I'd like you take a look.
Thanks in advance!
Select: Add divider theme for non-native optgroup
Docs: Add info for list-divider support for optgroups
The code looks good to me. I suppose you ran the select unit test and created a test page to see if it works as expected?
There is a small typo in the commit for the docs: the adjusted text should start with "a divider" instead of "divider". That & which was already in that line, looks a bit weird. Do you mind replacing that by "and"?
Can you add the option to the data attribute reference?
I forgot one thing for the docs: "The default theme for group dividers" should be "The default theme swatch for group dividers".
Docs: Correct wording at optgroup paragraph (select/custom.html)
Docs: Add dividerTheme paragraph (selects/options.html)
Docs: Add data-divider-theme to reference (data-attributes.html)
Hi @uGoMobi !
Sorry for delay. I was on holiday :-)
Thanks for looking into this. I've added some commits for the docs.
Demo at: http://jsfiddle.net/MauriceG/ULZfw/show/light/
Tests: 54 tests of 54 passed, 0 failed.
Hope you and your hardware are back soon!
hi @MauriceG !
I hope you enjoyed your holiday. I have a new computer so my hardware is all fine now :)
@toddparker - As discussed during last thursday's meeting I will merge this PR for 1.2 beta.
@johnbender @gseguin - Can one of you review the first two commits as well? Thanks!
I will add a unit test for this.
@MauriceG - Why did you close this PR?
I did close this accidently because I'm a github jackass ...
And I'm unable to reopen it.
I cannot re-open it either because you closed it yourself. New PR? :)
Select: Add optgroup theming for non-native select - #1
Fix for #4812
Replaced by PR #5033