Unset light shadow for input clear button and slider handle. #4813

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jaspermdegroot
Member

jaspermdegroot commented Aug 7, 2012

Issue: The light shadow for buttons in a theme A, B or C toolbar is also applied to the clear button of the search input and the slider handle (see: http://jsbin.com/atahip/65)

@toddparker

I have been looking for a solution without adding specific element classes to theme CSS, but didn't see any.
Applying the light shadow style only to buttons that are immediate children of the toolbar (.ui-bar-a > .ui-shadow) would fix the problem, but also create new ones.

Can I merge this PR?

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Aug 8, 2012

Member

@toddparker - Can I remove the bottom glow style?

Member

jaspermdegroot commented Aug 8, 2012

@toddparker - Can I remove the bottom glow style?

@toddparker

This comment has been minimized.

Show comment Hide comment
@toddparker

toddparker Aug 8, 2012

Contributor

Let's prototype this in a branch and decide.

.................................. . . . .
Todd Parker
Partner, Filament Group Inc.
102 South Street #3 Boston, MA 02111
todd@filamentgroup.com // 617.953.1617

On Aug 8, 2012, at 4:54 AM, "Jasper de Groot" notifications@github.com wrote:

@toddparker - Can I remove the bottom glow style?


Reply to this email directly or view it on GitHub.

Contributor

toddparker commented Aug 8, 2012

Let's prototype this in a branch and decide.

.................................. . . . .
Todd Parker
Partner, Filament Group Inc.
102 South Street #3 Boston, MA 02111
todd@filamentgroup.com // 617.953.1617

On Aug 8, 2012, at 4:54 AM, "Jasper de Groot" notifications@github.com wrote:

@toddparker - Can I remove the bottom glow style?


Reply to this email directly or view it on GitHub.

@jaspermdegroot jaspermdegroot reopened this Aug 8, 2012

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Aug 8, 2012

Member

Test page to compare bottom glow (current) versus dark shadow: http://jsbin.com/atahip/77

Member

jaspermdegroot commented Aug 8, 2012

Test page to compare bottom glow (current) versus dark shadow: http://jsbin.com/atahip/77

@ghost ghost assigned jaspermdegroot Aug 8, 2012

@jaspermdegroot

This comment has been minimized.

Show comment Hide comment
@jaspermdegroot

jaspermdegroot Sep 16, 2012

Member

Let's discuss for 1.3 what's best approach here. Closing this PR for now.

Member

jaspermdegroot commented Sep 16, 2012

Let's discuss for 1.3 what's best approach here. Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment