Popup transition direction reverse #4903

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

Addresses issue #4743 - Popup transition direction reverse by adding support for
data-direction="reverse" on popup widget links.

@chromepenguin chromepenguin popup.js: Added support for reverse transitions
Fixes #4743 - Popup transition direction reverse by adding support for
data-direction="reverse" on popup widget links.
d62e1a8
Member

@chromepenguin - Thanks for your PR! See my comment here #4743

groovy21 commented Oct 3, 2012

The slide transition can be used with reverse for left to right direction but when it transitions back it doesn't go from right to left. It should go from right to left on the way back. This especially noticeable for a popup. Can someone fix it please?

Member

@groovy21

Could you open a new issue for that and include a test page? See our Contributing Guidelines. Thanks!

groovy21 commented Oct 5, 2012

Thank you for guiding me. Issue #5134 has been logged

Owner

there are conflicts here and this is old closing but will be happy to review if PR is updated

@arschmitz arschmitz closed this Aug 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment