jQuery Tag Inserter: added check for jQuery existence in conditional tha... #4997

Merged
merged 1 commit into from Oct 15, 2012

Conversation

Projects
None yet
2 participants
@brianedgerton
Contributor

brianedgerton commented Sep 13, 2012

...t creates jQuery AMD definition. Fixes #4996. Win Phone 7/8: Slider onChange test failing.

WP 7 & 8 seem to have problems with jquery.tag.inserter.js. It seems that jQuery is not loaded in time for the conditional that creates the AMD definition. In WP, this conditional was always evaluating to true and causing the definition to run which, in turn, caused some strange event-related issue in the slider test. It may have been causing issues elsewhere, also. Will do more testing to see.

The drawback here is that AMD definition will probably never be loaded in WP. Based on the current logic, that seems like it will only be a problem when testing against jQuery versions < 1.7.0. I believe that leaves jQ 1.6.4 as the only supported version that will not run correctly.

Perhaps there is a better way to solve this problem to guarantee that all loading happens correctly, but it doesn't seem to happen in desktop browsers.

Brian Edgerton
jQuery Tag Inserter: added check for jQuery existence in conditional …
…that creates jQuery AMD definition. Fixes #4996. Win Phone 7/8: Slider onChange test failing.

gseguin added a commit that referenced this pull request Oct 15, 2012

Merge pull request #4997 from appendto/slider-onchange-fix
jQuery Tag Inserter: added check for jQuery existence in conditional tha...

@gseguin gseguin merged commit 371b5cb into jquery:master Oct 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment