Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
jQuery Tag Inserter: added check for jQuery existence in conditional tha... #4997
...t creates jQuery AMD definition. Fixes #4996. Win Phone 7/8: Slider onChange test failing.
WP 7 & 8 seem to have problems with jquery.tag.inserter.js. It seems that jQuery is not loaded in time for the conditional that creates the AMD definition. In WP, this conditional was always evaluating to true and causing the definition to run which, in turn, caused some strange event-related issue in the slider test. It may have been causing issues elsewhere, also. Will do more testing to see.
The drawback here is that AMD definition will probably never be loaded in WP. Based on the current logic, that seems like it will only be a problem when testing against jQuery versions < 1.7.0. I believe that leaves jQ 1.6.4 as the only supported version that will not run correctly.
Perhaps there is a better way to solve this problem to guarantee that all loading happens correctly, but it doesn't seem to happen in desktop browsers.