New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request for issue #4984 #5059

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@asyraf9

asyraf9 commented Sep 21, 2012

this is a pull request for a small code change to bring back _registerInternalEvents to allow overriding of JQM's event handlers in plugins as per this issue: #4984

I had to defer the registering of the callback to navreadyDeferred by binding it to mobileinit, because once registered to a deferred, it doesn't matter if _registerInternalEvents value is changed - deferred still points to the original callback.

so am not sure this is a good solution, but provided here for your review anyways.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Oct 2, 2012

Contributor

Merged as discussed in the issue.

Contributor

gabrielschulhof commented Oct 2, 2012

Merged as discussed in the issue.

gabrielschulhof added a commit that referenced this pull request Oct 2, 2012

[navigation] Re-instate $.mobile_registerInternalEvents - thanks asyr…
…af9 -- Fixes #4984, #5059

Conflicts:

	js/jquery.mobile.navigation.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment