Skip to content

pull request for issue #4984 #5059

Closed
wants to merge 1 commit into from

2 participants

@asyraf9
asyraf9 commented Sep 21, 2012

this is a pull request for a small code change to bring back _registerInternalEvents to allow overriding of JQM's event handlers in plugins as per this issue: #4984

I had to defer the registering of the callback to navreadyDeferred by binding it to mobileinit, because once registered to a deferred, it doesn't matter if _registerInternalEvents value is changed - deferred still points to the original callback.

so am not sure this is a good solution, but provided here for your review anyways.

@gabrielschulhof

Merged as discussed in the issue.

@gabrielschulhof gabrielschulhof added a commit that referenced this pull request Oct 2, 2012
@gabrielschulhof gabrielschulhof [navigation] Re-instate $.mobile_registerInternalEvents - thanks asyr…
…af9 -- Fixes #4984, #5059

Conflicts:

	js/jquery.mobile.navigation.js
9de514c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.