Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dialog: adjusted pagehide handler to not remove pages when dialogs open. Fixed #5239 #5253

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants

Dialog: adjusted pagehide handler to not remove pages when dialogs open. Fixed #5239 - dialog: External page being reloaded when dialog closes

@maurice2k maurice2k Dialog: adjusted pagehide handler to not remove pages when dialogs op…
…en. Fixed #5239 - dialog: External page being reloaded when dialog closes
5b4c8b1
Member

gseguin commented Mar 20, 2013

@maurice2k, Thank you for the pull request! It seems like you haven't signed a CLA. Please visit http://contribute.jquery.org/CLA/ and sign it so we can look into your PR.

Thank you.

Just signed it...

hi, what's the status for this merge? The bug is pretty annoing...

Awaiting this merge so long...
Please fix small issues like this sooner as it breaks the whole logic of dialogs.
(NOTE: Already tried to use the Popup plugin instead, but it does not behave correctly either (positionTo bugs with the virtual keyboard on mobile devices) )

Owner

arschmitz commented Aug 6, 2013

sorry it took us so long to get to this but there are some conflicts here i will be happy to review this if it is updated to fix conflicts because this is over 5 months old im going to close for now but will reopen if there is an update to the PR

@arschmitz arschmitz closed this Aug 6, 2013

Member

jaspermdegroot commented Aug 6, 2013

Just wanted to note that we deprecate the dialog widget in 1.4 and will make it an option in the page widget for 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment