Issue #5314 - Clean up dynamic-samples/category.php #5315

Merged
merged 1 commit into from Nov 22, 2012

Conversation

Projects
None yet
2 participants
Member

Krinkle commented Nov 22, 2012

  • Fixes PHP warnings (see #5314, follows-up cac2032)
  • Added charset in Content-Type header
  • Used json_encode instead of homebrew unescaped json encoder.
Clean up dynamic-samples/category.php. Fixes #5314.
Fixes there errors:

PHP Notice:  Use of undefined constant vehicles - assumed 'vehicles' in ./docs/pages/dynamic-samples/category.php on line 53

PHP Notice:  Use of undefined constant name - assumed 'name' in ./docs/pages/dynamic-samples/category.php on line 54

PHP Notice:  Use of undefined constant description - assumed 'description' in ./docs/pages/dynamic-samples/category.php on line 55

PHP Notice:  Use of undefined constant items - assumed 'items' in ./docs/pages/dynamic-samples/category.php on line 56

PHP Notice:  Use of undefined constant name - assumed 'name' in ./docs/pages/dynamic-samples/category.php on line 58

PHP Notice:  Use of undefined constant name - assumed 'name' in ./docs/pages/dynamic-samples/category.php on line 61

PHP Notice:  Use of undefined constant name - assumed 'name' in ./docs/pages/dynamic-samples/category.php on line 64

PHP Notice:  Undefined index: id in ./docs/pages/dynamic-samples/category.php on line 74

PHP Notice:  Undefined index:  in ./docs/pages/dynamic-samples/category.php on line 82

PHP Notice:  Undefined index: HTTP_X_REQUESTED_WITH in ./docs/pages/dynamic-samples/category.php on line 88

Also added charset in Content-Type header and used json_encode
instead of homebrew unescaped json encoder.

Follows-up cac2032

toddparker added a commit that referenced this pull request Nov 22, 2012

Merge pull request #5315 from Krinkle/php-errors
Issue #5314 - Clean up dynamic-samples/category.php. Thanks @krinkle

@toddparker toddparker merged commit ef8cd40 into jquery:master Nov 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment