collapsise : abitilty to have no icon #5327

Merged
merged 1 commit into from Dec 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

ErwanMAS commented Nov 24, 2012

move default values from collapsedIcon / expandedIcon / iconPos in the "options"
section of the widget instead in the main code .

so we have the ability do not display a icon for collapsible ( with setting collapsedIcon to false )

@ErwanMAS ErwanMAS [collapsible] move default values from collapsedIcon / expandedIcon /…
… iconPos in the "options" section of the widget instead in the main code .

               so we have the ability do not display a icon for collapsible .
2af7570
Member

jaspermdegroot commented Nov 29, 2012

@ErwanMAS

Thanks for the PR. I will test this and see if we need to make adjusments in CSS as well for this no-icon option. After that we can pull this in for 1.3.

Member

jaspermdegroot commented Nov 30, 2012

@ErwanMAS

The collapsible unit tests 12.3 and 12.4 fail. Can you give that a look? Thanks!

@jaspermdegroot jaspermdegroot merged commit 2af7570 into jquery:master Dec 3, 2012

Member

jaspermdegroot commented Dec 3, 2012

@ErwanMAS

I made the required changes to make things work in collapsible sets. The tests pass now. I also made a minor change in the CSS so it covers a collapsible without icon as well. Your commit and these changes are merged in branch master now.

Note that if you want a collapsible to have no icons and the correct CSS to be applied, you have to set all three options collapsedIcon, expandedIcon and iconpos to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment