Improve zoom plugin #5407

Closed
wants to merge 3 commits into from

4 participants

@doom777

Zoom plugin was scanning for initially disabled zoom with an improper regex that didn't catch every case. This patches the regex string, which will now catch more cases where zoom should be set to to initiallydisabled.

See later comments of issue #4024 where white screen flashes during transitions; this is what fixed it for me.

@nickwb

Good patch.
Perhaps you should consider adding support for user-scalable=0 also.

@doom777

@nickwb you're right, according to http://dev.w3.org/csswg/css-device-adapt/#meta-properties, acceptable values are yes, ≤-1, ≥1 or no, and between 1 and -1

@doom777 doom777 Update js/jquery.mobile.zoom.js
fixed up more regex to be more to spec; see http://dev.w3.org/csswg/css-device-adapt/#meta-properties
which says user-scalable can be yes, no, or a number, where anything between 1 and -1 is interpreted as no. Also switched to non-capturing groups
496c305
@gseguin
jQuery Foundation member

@doom777, It seems like you haven't signed a CLA. Please visit http://contribute.jquery.org/CLA/ and sign it so we can look into your PR.

Thank you.

@arschmitz
jQuery Foundation member

no reply to CLA request closing

@arschmitz arschmitz closed this Aug 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment