Issue 1383 - fixes to handle single & double quotes in data-url #5435

Closed
wants to merge 4 commits into
from

Projects

None yet

3 participants

@SixtoSaez

In my comment to this issue (#1383), there's a sample page that reproduces this issue.

In this branch, I first committed new unit tests that fail against against the current navigation code. Next I committed a couple of changes needed to handle these quote characters. I've only tested the fixes in Chrome & FireFox. Please let me know if you have any questions about the changes or the use case. Thanks for the consideration!

SixtoSaez added some commits Jan 11, 2013
@SixtoSaez SixtoSaez Added tests that demonstrate the bug described in issue 1383
These tests run against the unmodified code to verify the fixes made in the next commit
fdb913c
@SixtoSaez SixtoSaez Fixes for handling single and double quote chars in data-url fc2d85b
@SixtoSaez SixtoSaez Removed unneeded variable used for dev debugging 46ebd07
@SixtoSaez SixtoSaez Replace unneeded variable
Use a direct reference since the variable isn't used for anything else
a861d83
@gseguin
Member
gseguin commented Mar 20, 2013

@SixtoSaez, Thank you for the pull request! It seems like you haven't signed a CLA. Please visit http://contribute.jquery.org/CLA/ and sign it so we can look into your PR.

Thank you.

@SixtoSaez

Sorry about that, I must have missed that in the PR instructions. I just signed the CLA. Thanks for the reply & consideration!

@arschmitz
Member

There are merge conflicts here if you would like to update pr ill be happy to look at it until then closing

@arschmitz arschmitz closed this Aug 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment